Fix sort ordering and table height on welcome page#76
Open
bendichter wants to merge 2 commits intomainfrom
Open
Fix sort ordering and table height on welcome page#76bendichter wants to merge 2 commits intomainfrom
bendichter wants to merge 2 commits intomainfrom
Conversation
Use 'ordering' instead of 'order' as the query parameter for the DANDI API (Django REST Framework convention), fixing sort-by-modified. Remove maxHeight and overflow constraints so the dandiset table fits its content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The table was showing draft_version.modified but the API sorts by the top-level dandiset.modified field. These dates differ significantly, making the sort appear broken. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orderinginstead oforderas the query parameter for the DANDI API (Django REST Framework convention), so sorting by modified date actually works.maxHeightand inner scroll constraints so the dandiset table fits its content instead of requiring a separate scrollbar.Test plan
🤖 Generated with Claude Code