Migrate to SunKit from Solar #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Turns out Solar is much more performant. I may do some investigation into why this is, but likely it's somewhat cheaper to instantiate and update a class compared to recreating the Sun struct on every re-render (e.g. TimeMachine update) |
Resolves merge conflicts keeping main branch's refactored view structure while using SunKit types. Also adds performance optimizations to reduce Sun instance creation: - Cache Sun instances in views using @State with onChange for date updates - Use SunKit's setDate() to avoid recomputing sun events for same-day changes - Pre-compute Sun in widget timeline entries to eliminate render-time computation - Add SunKit++ extension methods that accept cached comparator Sun instances Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.