Replace FREE with Get to match the App Store#40
Open
ricsantos wants to merge 1 commit intodanielamitay:masterfrom
Open
Replace FREE with Get to match the App Store#40ricsantos wants to merge 1 commit intodanielamitay:masterfrom
ricsantos wants to merge 1 commit intodanielamitay:masterfrom
Conversation
|
The text comes directly from their API. But might be useful in some cases to adjust it. ¯_(ツ)_/¯
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for updating the repo to match the App Stores current design! As a long time user of
DAAppsViewControllerthis is great to see.I updated one of my apps, and noticed it says "FREE" for free apps, but the App Store says "Get".
Looked into the code, seems the Free string comes from the API, so did a little match and replace.
If this is something you are OK with, merge away! If not, no drama.