Add param to prevent replacement of hyphen with underscore#29
Open
jkrech17 wants to merge 3 commits intodaniellawrence:masterfrom
jkrech17:master
Open
Add param to prevent replacement of hyphen with underscore#29jkrech17 wants to merge 3 commits intodaniellawrence:masterfrom jkrech17:master
jkrech17 wants to merge 3 commits intodaniellawrence:masterfrom
jkrech17:master
Conversation
added 3 commits
October 19, 2015 12:04
…ens with underscores by default
…ens with underscores by default
…ens with underscores by default
Owner
|
Thanks for the pull request, could you rebase from master and update this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We publish to graphite and utilize hyphens in metric names, so appears to be a legal character. Added parameter to decide whether to replace hyphen.