Handle ignored_by_productivity for productivity techs#93
Open
JFletcher94 wants to merge 1 commit intodanielmartin0:mainfrom
Open
Handle ignored_by_productivity for productivity techs#93JFletcher94 wants to merge 1 commit intodanielmartin0:mainfrom
JFletcher94 wants to merge 1 commit intodanielmartin0:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
process_technology_recipe_productivity_effectsto take into accountignored_by_productivityignored_by_productivity>=amount(oramount_max), that product will be ignored for evaluating the recipeallow_multiple_resultsisfalse, because there's only one "productivity-capable" product (i.e. only one product will actually be affected by the productivity change)process_technology_recipe_productivity_effectsto not count multiple products with the same name as "different", for the purposes ofallow_multiple_resultsgolden-science-pack(one has a probability)typewas documented as only applying if usingnamebut not if usingcategorytypewas being evaluated even if usingcategoryChecklist
changelog.txthas been updatedREADME.mdhas been updated (documentation section and/or Contributors list)Testing Notes
I ran a diff test with the "Enable All Planets" mod enabled, and the only diffs (aside from what I was trying to get working for Crucible) were a few recipes from Cubium that have non-prod-capable byproducts were now included in productivity techs:
dream-processing-unitcube-jelly-plasticrocket-fuel-dreamsdream-concreterefined-dream-concrete