refactor(metrics): export struct fields and use _test package#471
Closed
refactor(metrics): export struct fields and use _test package#471
Conversation
danroc
force-pushed
the
refactor/metrics-test-package
branch
2 times, most recently
from
cc70912 to
d69d32b
Compare
Make PrometheusCollector fields public to enable black-box testing with the `package metrics_test` convention. Add version info test.
danroc
force-pushed
the
refactor/metrics-test-package
branch
from
d69d32b to
ab4c3a6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 12 12
Lines 756 756
=======================================
Hits 688 688
Misses 62 62
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrometheusCollectorstruct fields to enable black-box testing with thepackage metrics_testconventionPrometheusCollectorassertCounterValuehelper to top of test file with other helpersTestNewCollector_VersionInfotestFollow-up to #470.