Skip to content

DAOS-18356 object: skip key checksum for value enumeration #17319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gnailzenh wants to merge 3 commits into
base: master
Choose a base branch
from
Open

DAOS-18356 object: skip key checksum for value enumeration #17319

gnailzenh wants to merge 3 commits into from
+60 −105

Conversation

@gnailzenh
Copy link
Contributor

@gnailzenh gnailzenh commented Dec 26, 2025

During enumeration, key and value checksum verification are performed separately. In the value path (csum_enum_verify_recx/sv), a dummy IOD is passed to daos_csummer_verify_iod(), which causes the ISA-L SHA-256 update (isal_mh_sha256_update()) to fail.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@gnailzenh
DAOS-18356 object: skip key checksum for value enumeration
74db22c 
During enumeration, key and value checksum verification are performed
separately. In the value path (csum_enum_verify_recx/sv), a dummy IOD
is passed to daos_csummer_verify_iod(), which causes the ISA-L SHA-256
update (isal_mh_sha256_update()) to fail.

Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh gnailzenh requested review from a team as code owners December 26, 2025 07:39
@github-actions
Copy link

github-actions bot commented Dec 26, 2025 •
edited
Loading

Ticket title is 'scrubber/rebuild.py:TestScrubberEvictWithRebuild.test_target_eviction_during_rebuild - engine core dump'
Status is 'In Review'
Labels: 'ci_master_weekly,weekly_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18356

liuxuezhao
liuxuezhao previously approved these changes Dec 26, 2025
View reviewed changes
NiuYawei
NiuYawei reviewed Dec 26, 2025
View reviewed changes
src/object/cli_shard.c Outdated
ci_to_compare);
rc = csum_enum_verify_sv(csummer, rec, &enum_type_val, ci_to_compare);
csummer->dcs_skip_key_calc = skip_key_calc;
csummer->dcs_skip_key_verify = skip_key_verify;
Copy link
Contributor

@NiuYawei NiuYawei Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks there are some other cases need be fixed as well, for example, csummer_verify_recx() in src/object/srv_enum.c.

Copy link
Contributor Author

@gnailzenh gnailzenh Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, thanks

@gnailzenh
DAOS-18356 object: code cleanup
03ee1ef 
Signed-off-by: Liang Zhen <gnailzenh@gmail.com>
@gnailzenh gnailzenh requested a review from a team as a code owner December 28, 2025 17:36
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 28, 2025
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 28, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17319/2/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 30, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17319/3/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 30, 2025

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17319/3/testReport/

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 31, 2025

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17319/4/execution/node/1343/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 31, 2025

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17319/4/execution/node/1310/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiuYawei NiuYawei NiuYawei left review comments

@liuxuezhao liuxuezhao liuxuezhao left review comments

@wangshilong wangshilong Awaiting requested review from wangshilong

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

priority Ticket has high priority (automatically managed)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gnailzenh @daosbuild3 @liuxuezhao @NiuYawei