runtimestate: Remove stalled state for non-stalled runtimes#68
Merged
runtimestate: Remove stalled state for non-stalled runtimes#68
Conversation
Fix the stalled state being set for runtimes that were stalled at one point but are no longer stalled. Signed-off-by: joshvanl <me@joshvanl.dev>
There was a problem hiding this comment.
Pull request overview
This PR fixes orchestration runtime state handling so that a previously-set Stalled flag is cleared once subsequent non-stalled history events are successfully processed, preventing runtimes from incorrectly remaining in a stalled status after progressing.
Changes:
- Clear
s.Stalledon any successfully-processed non-stalled history event inaddEvent. - Add unit tests covering stalled state set/clear behavior for new events and replayed (old) events.
- Add a regression test ensuring stalled state is preserved when
AddEventreturns a duplicate-event error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backend/runtimestate/runtimestate.go | Clears prior stalled state when processing a non-stalled event successfully. |
| backend/runtimestate/runtimestate_test.go | Adds coverage for stalled-state transitions across new events, old history replay, and error paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh van Leeuwen <me@joshvanl.dev>
yaron2
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the stalled state being set for runtimes that were stalled at one point but are no longer stalled.