Skip to content

Removes unused protobuf#70

Merged
JoshVanL merged 1 commit intodapr:mainfrom
JoshVanL:remote-unused-protobuf
Mar 6, 2026
Merged

Removes unused protobuf#70
JoshVanL merged 1 commit intodapr:mainfrom
JoshVanL:remote-unused-protobuf

Conversation

@JoshVanL
Copy link

@JoshVanL JoshVanL commented Mar 5, 2026

Based on dapr/durabletask-protobuf#31

Signed-off-by: joshvanl <me@joshvanl.dev>
Copilot AI review requested due to automatic review settings March 5, 2026 17:29
@JoshVanL JoshVanL requested a review from a team as a code owner March 5, 2026 17:29
JoshVanL added a commit to JoshVanL/dapr that referenced this pull request Mar 5, 2026
Based on dapr/durabletask-go#70

Signed-off-by: joshvanl <me@joshvanl.dev>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the durabletask protobuf submodule and regenerates Go protobuf/grpc bindings to drop unused services/methods.

Changes:

  • Bumps submodules/durabletask-protobuf to a newer commit (per upstream PR).
  • Removes unused gRPC service/method stubs and deletes an unused generated backend_service_grpc.pb.go.
  • Cleans up go.mod by removing now-unneeded indirect dependencies.

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
submodules/durabletask-protobuf Updates the protobuf submodule commit to pull in upstream removals.
go.mod Updates Go version directive and prunes indirect deps after protobuf changes.
backend/executor.go Removes server method stubs that correspond to removed protobuf service methods.
api/protos/runtime_state.pb.go Regenerated code header reflects updated protoc version.
api/protos/orchestrator_service_grpc.pb.go Regenerated gRPC bindings removing deprecated/unused RPCs.
api/protos/backend_service_grpc.pb.go Removes generated backend service bindings (no longer present/used).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@JoshVanL JoshVanL merged commit 3cf8cb0 into dapr:main Mar 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants