Closed
Conversation
Signed-off-by: Albert Callarisa <albert@diagrid.io>
filintod
approved these changes
Oct 9, 2025
filintod
reviewed
Oct 13, 2025
| @@ -1 +1 @@ | |||
| grpcio-tools==1.62.3 # 1.62.X is the latest version before protobuf 1.26.X is used which has breaking changes for Python | |||
| grpcio-tools==1.75.1 | |||
There was a problem hiding this comment.
let's add a warning about upgrading this value as it could break some installations
if the major version of protobuf changes.
we should check install_requires in https://github.com/grpc/grpc/blob/master/tools/distrib/python/grpcio_tools/setup.py#L349
for example currently protobuf>=6.31.0,<7.0.0
if we want to update this grpcio-tools version, and the protobuf value changes to >=7 we need to change dependencies in python dapr-ext-workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpcio-toolsto 1.75.1