Makes data argument optional on transactional delete#752
Merged
berndverst merged 4 commits intodapr:mainfrom Nov 21, 2024
Merged
Makes data argument optional on transactional delete#752berndverst merged 4 commits intodapr:mainfrom
berndverst merged 4 commits intodapr:mainfrom
Conversation
Signed-off-by: Elena Kolevska <elena@kolevska.com>
famarting
approved these changes
Nov 4, 2024
berndverst
suggested changes
Nov 11, 2024
Member
berndverst
left a comment
berndverst
left a comment
There was a problem hiding this comment.
Fix type check
tox -e type tox -e mypy
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 86.63% 86.03% -0.60%
==========================================
Files 84 87 +3
Lines 4473 4783 +310
==========================================
+ Hits 3875 4115 +240
- Misses 598 668 +70 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Contributor
Author
|
Fixed. Thanks @berndverst |
berndverst
approved these changes
Nov 21, 2024
elena-kolevska
added a commit
to elena-kolevska/python-sdk
that referenced
this pull request
Mar 6, 2025
* Makes data argument optional on transactional delete Signed-off-by: Elena Kolevska <elena@kolevska.com> * linter Signed-off-by: Elena Kolevska <elena@kolevska.com> * Linter/type check Signed-off-by: Elena Kolevska <elena@kolevska.com> --------- Signed-off-by: Elena Kolevska <elena@kolevska.com> Co-authored-by: Bernd Verst <github@bernd.dev> Signed-off-by: Elena Kolevska <elena@kolevska.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the
dataparameter not required inTransactionalStateOperationforDELETEoperations.Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Release Note
RELEASE NOTE: FIX Makes data argument optional on transactional delete