This repository was archived by the owner on Dec 28, 2022. It is now read-only.
Add support for Brave Browser and Waterfox Current#260
Draft
grahamperrin wants to merge 5 commits intodarktrojan:masterfrom
Draft
Add support for Brave Browser and Waterfox Current#260grahamperrin wants to merge 5 commits intodarktrojan:masterfrom
grahamperrin wants to merge 5 commits intodarktrojan:masterfrom
Conversation
Aiming to fix darktrojan#250 * focusing first on Linux
Addition of `waterfox-current` re: darktrojan#250 (comment)
NB **some guesswork** because I don't have a Mac on which to test.
NB **much guesswork**: * I'm not a developer * Microsoft Windows is complicated to me (I normally use FreeBSD-CURRENT) – it will be good if someone else can test and correct this code.
|
@grahamperrin Hi, I tried your modifications from your 7510cb2 commit, but it didn't do anything. I had to replace |
|
I found a way to make it work with Waterfox on Windows:
Save, run as instructed, it should now work. |
Author
|
(This fell off my radar a few months ago, sorry. All suggestions/fixes welcome.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250 (hopefully).
This draft PR will almost certainly require corrections to code from people who are familiar with:
– on:
The commits here are based upon the patch with which @Sawyer07 opened #250.
Please note:
– and so on, so there's guesswork by me in all three of the files.