This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Open
Conversation
Author
|
Note: doc check seems to be failing due to pre-existing typo |
Owner
|
Thanks for this, I'll take a look soon 👀 |
gavinmorrow
added a commit
to gavinmorrow/comfy
that referenced
this pull request
Jun 28, 2024
|
is there a new release coming soon that might incorporate this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be honest I'm not sure whether this is the correct way to fix this, but it seems that #101 is caused by cd52f9f which moved the keyboard event handling to use
Event::DeviceEventinstead ofEvent::WindowEvent->WindowEvent::KeyboardInput. In my testingEvent::DeviceEventis not fired when pressing keys (on macOS). This doesn't revert the above commit, it merely moves the code to useWindowEvent::KeyboardInputinstead.Fixes #101