This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Update ASSETS_LOADED one frame later so users can skip the placeholder.#84
Open
yaymukund wants to merge 1 commit intodarthdeus:masterfrom
Open
Update ASSETS_LOADED one frame later so users can skip the placeholder.#84yaymukund wants to merge 1 commit intodarthdeus:masterfrom
yaymukund wants to merge 1 commit intodarthdeus:masterfrom
Conversation
Author
|
This doesn't seem to fix things for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When textures are rendered, there is a placeholder image that flashes for a single frame before the actual image. Here is an example of how it looks:
Example reproduction:
Here's my attempt to track it down:
run_early_update_stages()processes the asset queues...inc_assets_loaded()saying it is "loaded." It is not actually loaded yet.Fix in this branch. We just put off the rendering by 1 frame.