Fix Gradle 8 compatibility: replace deprecated destinationDir property#10
Open
beau-house wants to merge 1 commit intodashdoc:mainfrom
Open
Fix Gradle 8 compatibility: replace deprecated destinationDir property#10beau-house wants to merge 1 commit intodashdoc:mainfrom
beau-house wants to merge 1 commit intodashdoc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Android build failures on Gradle 8.x (React Native 0.71+).
The problem
destinationDirwas deprecated in Gradle 7 and removed in Gradle 8, causing builds to fail with: "Could not get unknown property 'destinationDir' for task... of type org.gradle.api.tasks.compile.JavaCompile"The fix
Replace
destinationDirwithdestinationDirectory, which has been available since Gradle 6.1 (backward compatible).References
Gradle 7 to 8 migration guide
destinatoinDirectory API docs
This is a small one line fix so I thought I'd just create a PR rather than opening an issue. Thank you for this library!