This repository was archived by the owner on Mar 6, 2019. It is now read-only.
Style enhancement suggestion for grid (bottom of get-dash page)#383
Open
melissjs wants to merge 4 commits intodashpay:masterfrom
Open
Style enhancement suggestion for grid (bottom of get-dash page)#383melissjs wants to merge 4 commits intodashpay:masterfrom
melissjs wants to merge 4 commits intodashpay:masterfrom
Conversation
Contributor
|
Thank you, @melissjs for your contribution! I will review & get back to you as soon as possible. Please give me a few days. |
Author
|
Adding simple blog search function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The styling of this grid is a little unorganized. The icons were centered for small mq views but left aligned for others. I thought it looked cleaner to center everything in the grid items uniformly for each media queries.
It also bothered me that the first item had only a title and no text. I made my suggested change, I feel like this helps with both visual and content uniformity.
I looked at this page from responsive and mobile views, I believe this is the only place the grid is used, but should you choose to accept this PR, please check further to make sure my style changes didn't adversely effect anything else.