Open
Conversation
Address data-driven-science#5 The DBHandler class works with two test cases. The dbhandle.py script uses DBHandler for all its functions. * The tests in the test/ directory are broken. * There are still issues when the tests shutdown their own database instance. It is probably better to start the database and then test rather than allow the tests to start their own DB instances
Address data-driven-science#5 Currently the tests run 5 times. This is an issue with Flask testing and nosetest working together. Each test class seems to rerun the entire test suite.
Address data-driven-science#5 - Use test/config.py for all test configuration. - Use Handler to run the database daemon. - Delete the database on tear down. - Use TestCase instead of LiveServerTestCase to avoid running the tests multiple times.
Conflicts: dbhandle.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.