fix piece type inference for non-inline preparations#614
Merged
Conversation
the migration heuristic only checked car_blocks.file_id to distinguish data vs dag pieces. non-inline preps don't store file refs in car_blocks (data is on disk), so all their pieces were misclassified as dag. add num_of_files > 0 as a signal, which is only set by the packer.
Collaborator
Author
|
(this is totally on me, I failed to think about the materialized cars use case) |
lanzafame
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the migration heuristic only checked car_blocks.file_id to distinguish data vs dag pieces. non-inline preps don't store file refs in car_blocks (data is on disk), so all their pieces were misclassified as dag, oops
add num_of_files > 0 as a signal, which is only set by the pack job
props to casey for discovering this