Updates to readme, and batch inference #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated batch inference fields to match what is expected from the monitoring script Adding example of batch input table creation to the readme
ThomasHenckel
changed the title
Contributor
Author
|
What do you think, can this be merged, it fixes an issue when running the monitoring example |
arpitjasa-db
reviewed
Feb 5, 2025
Collaborator
arpitjasa-db
left a comment
arpitjasa-db
left a comment
There was a problem hiding this comment.
Hey @ThomasHenckel thanks for doing this! Left a few comments, but mostly looks good. Can you add a screenshot/link to an instantiated repo to confirm the whole flow works as expected?
...ut_root_dir}}/{{template `project_name_alphanumeric_underscore` .}}/resources/README.md.tmpl
Outdated
Show resolved
Hide resolved
...ut_root_dir}}/{{template `project_name_alphanumeric_underscore` .}}/resources/README.md.tmpl
Outdated
Show resolved
Hide resolved
This was referenced Feb 21, 2025
Co-authored-by: Arpit Jasapara <87999496+arpitjasa-db@users.noreply.github.com>
Contributor
Author
|
Hi @arpitjasa-db thanks for the review comments, they have been applied. |
This was
linked to
issues
Feb 21, 2025
arpitjasa-db
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated batch inference fields to match what is expected from the monitoring script Adding example of batch input table creation to the readme
monitoring-resource.yml expects model_id and timestamp and that predictions is not a string