Make curl in install scripts show errors and exit with non-zero status #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only
-fand-Sare new.Both these new flags could potentially have surfaced an underlying issue in databricks/cli#2307.
With this change, all curl invocations in this repo use the same set of flags.
Description:
-f/--failSilently fails on HTTP errors (e.g., 404, 500). Prevents output of error pages to stdout/stderr, returning exit code 22 instead. Critical for scripting to avoid processing invalid responses.
-s/--silentSuppresses progress meters, error messages, and other non-essential output. Ensures clean output for piping or saving to files.
-S/--show-errorOverrides -s to display errors if they occur. Balances silent operation with actionable error reporting.
-L/--locationFollows HTTP redirects (3xx responses). Essential for URLs that point to mirrored or updated resources (e.g., download links that redirect to CDNs).