Skip to content

Conversation

@kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented Jan 13, 2026

No description provided.

@kmoscoe kmoscoe requested a review from clincoln8 January 13, 2026 20:22
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kmoscoe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the sample basic_agent to establish its default connection to a hosted Multi-Cloud Platform (MCP) server via HTTP. This change simplifies the agent's operational setup by eliminating the need for a local standard I/O server, thereby leveraging a remote service for its functionality.

Highlights

  • Connection Method Update: The sample agent's connection to the MCP server has been updated from using local standard I/O (StdioConnectionParams) to a hosted HTTP endpoint (StreamableHTTPConnectionParams).
  • Dependency Changes: Imports for StdioConnectionParams and StdioServerParameters have been removed, and StreamableHTTPConnectionParams has been added to support the new HTTP connection.
  • Class Name Refinement: The McpToolset class name has been updated to MCPToolset to reflect a potential naming convention change.
  • Hosted Server Configuration: The MCPToolset is now configured to connect to https://api.datacommons.org/mcp and includes necessary HTTP headers such as Content-Type, Accept, and X-API-Key.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kmoscoe kmoscoe requested a review from keyurva January 13, 2026 20:22
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the basic sample agent to connect to the hosted Data Commons MCP server by default, replacing the previous implementation that used a local stdio server. The changes correctly use StreamableHTTPConnectionParams to configure the connection. My review includes a suggestion to make the MCP server URL configurable through an environment variable, which would improve the sample agent's flexibility for different environments.

),
MCPToolset(
connection_params=StreamableHTTPConnectionParams(
url=f"https://api.datacommons.org/mcp",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The MCP server URL is hardcoded. For better flexibility, consider making this configurable via an environment variable, similar to DC_API_KEY and AGENT_MODEL. This would allow the agent to easily connect to different environments (e.g., staging, local) without code changes.

Suggested change
url=f"https://api.datacommons.org/mcp",
url=os.environ.get("MCP_URL", "https://api.datacommons.org/mcp"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant