-
Notifications
You must be signed in to change notification settings - Fork 130
Import automation improvements #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @vish-cs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the parameter handling within the import automation system. It introduces a more consistent naming convention for import status parameters, enhances the parameter extraction utility to gracefully handle different casing styles, and expands the data points captured for import status. These changes aim to improve the clarity, maintainability, and extensibility of the import process by standardizing data representation and consolidating related logic. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request cleans up and standardizes the parameter names for import status updates, moving from camelCase to snake_case for consistency within the Python code. The refactoring also includes consolidating two functions into one, which improves maintainability by reducing code duplication. My review includes a couple of suggestions for import_utils.py to further enhance the parameter handling logic. One suggestion is for improving clarity by renaming a function parameter, and the other addresses a potential issue in how the next_refresh timestamp is calculated to prevent incorrect data from being stored.
4343496 to
d9c5c63
Compare
- Update version history for spanner ingestion - Use update_import_status cloud function for feed based imports - Update staging version file for feed based imports - Update import param names for consistent processing - Use http type handler for feed based imports - Use a single graph path instead of list
Uh oh!
There was an error while loading. Please reload this page.