-
Notifications
You must be signed in to change notification settings - Fork 29
Populate provenance nodes for spanner ingestion #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @vish-cs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the Spanner ingestion pipeline by enabling the population of provenance nodes and edges, which is crucial for data lineage and traceability. It refactors the data processing mechanism to accommodate multiple graph data sources and different file formats, enhancing the pipeline's flexibility and robustness. These functional changes are complemented by necessary updates to the Spanner schema and the Dataflow job configuration script to ensure seamless operation and improved resource management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Spanner ingestion pipeline to populate provenance nodes by processing a list of graph data paths for each import. The changes are logical, but I've identified a critical issue that could lead to a pipeline crash, along with a couple of medium-severity concerns regarding code maintainability and robustness. My main feedback points include fixing a potential NullPointerException during JSON parsing, improving the file type detection logic, and questioning the addition of an apparently unused database table.
Use import_metadata_mcf.mcf file in GCS to populate provenance nodes
Also, split latestVersion into latestVersion and graphDataPath fields. Convert to array to support multiple paths
Update spanner schema