Feat/snowflake ddl sql import solve #789 and #885 schema.description and properties.description on snowflake and postgresql #790
Conversation
|
Can you elaborate on the error with sqlglot? We'd rather want to fix the issue there and not re-introduce the previously removed library. |
|
I found the `AUTOINCREMENT START # INCREMENT [NOORDER|ORDER] do sqlglot fail, a PR is send to them (sqlglot team already) tobymao/sqlglot#5223, |
…d).lint(enabled_linters=set()).has_passed()
|
@simonharrer Can I ask for a review, the comment on snowflake are now well supported for snowflake, and simpleddl is removed. |
…aresma/datacontract-cli into feat/snowflake_ddl_sql_import
|
@simonharrer is it possible to merge this fix for snowflake sql ddl import for comment, tags ? |
|
I include a fix for the T-SQL money data type to decimal related to #751 |
|
@simonharrer please review this PR, it's 2 month old already and solve attributes and table comment |
|
I'll adapt soon the move from DataContractSpecification to ODCS , re-introduce table tags (snowflake) and table comment (description), add timestamp as logicaltype as 3.1 allows it. |
Hi, I use snowflake as main EDW workspace, I notice some regression when simple-ddl-parser was replaced by sqlglot unfortunatly snowflake ddl import is a show stopper for me, in the migration of the catalog into datacontracts.
I take care to maintain sqlglot / sqlserver fonctionnality as is. the sql server test pass.
regression on tags, ddl comment/description, and data type