Open
Conversation
feat: adding support to sftp server. only test is working currently
Feature/sftp
simonharrer
reviewed
Nov 13, 2025
simonharrer
reviewed
Nov 13, 2025
simonharrer
reviewed
Nov 13, 2025
simonharrer
reviewed
Nov 13, 2025
simonharrer
reviewed
Nov 13, 2025
build: assuming only data are on sftp servers Add Excel files on sftp
Contributor
Author
|
Hey @simonharrer happy new year 😄 |
| def get_supported_formats(cls): | ||
| return list(map(lambda c: c.value, cls)) | ||
|
|
||
| def setup_sftp_filesystem(url: str): |
Contributor
There was a problem hiding this comment.
We should not add the function here in the interface.
Contributor
There was a problem hiding this comment.
Why was the file mode changed?
| OpenDataContractStandard object | ||
| """ | ||
| if not os.path.exists(excel_file_path): | ||
| if not (excel_file_path.startswith("sftp://") or os.path.exists(excel_file_path)): |
Contributor
There was a problem hiding this comment.
What is the use case for sftp support for the excel importer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR close #852
Sftp is now usable for functions : lint / import / test