feat: export custom model (like as dbt models .sql)#978
Open
AntoineGiraud wants to merge 4 commits intodatacontract:mainfrom
Open
feat: export custom model (like as dbt models .sql)#978AntoineGiraud wants to merge 4 commits intodatacontract:mainfrom
AntoineGiraud wants to merge 4 commits intodatacontract:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Hi, this is a PR to add the
--schema_namewhen we do a custom exportexample :
datacontract export tests/fixtures/custom/export/datacontract.yaml --format custom --template tests/fixtures/custom/export_model/template.sql --schema-name line_itemswhy
i wasn't able to do it previously and it felt odd to have a for loop to export a custom dbt model ... that is supposed to be 1 model per file
to be discused
I tried to update the README.md acordingly
This PR is in draft to open the discusion with materials to chat on
i'm also puzzled on if the "data_contract" passed to the
template.filewill be an ODCS exclusivelyor could it still be the ol' datacontract spec ?!
though for now the method is
def to_custom(data_contract: OpenDataContractStandard, template_path: Path) -> str:PushToProd checks