Open
Conversation
… needed in snowflake provider credentials
JonnyDaenen
reviewed
May 6, 2025
There was a problem hiding this comment.
General questions on the folder structure:
- why do we have a .dlt (symlink?) in this folder?
- we use src/dlt_example, why not top-level structure as dlt does with
dlt init?
|
|
||
| COPY --from=ghcr.io/astral-sh/uv:0.6.14 /uv /bin/uv | ||
|
|
||
| RUN set -eux; \ |
Author
There was a problem hiding this comment.
Can be removed. I've added them out of habit, to ensure bash behaves more like the languages we're used to and to error out on the first failed command (e-flag). Since none of the 3 commands here is likely to give an error, it can (and will) be removed.
JonnyDaenen
reviewed
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a demo project that migrates some tables from an Oracle db to Snowflake using dlthub.
To setup the Oracle DB (on Amazon RDS) and configure the various roles for Snowflake, one can use Terraform in the infra folder.
uvis used for Python dependency and venv management.The dlthub command is triggered from an OCI container that is itself launched by Conveyor's Airflow ConveyorContainerOperator.
Little aside: this is the commit template from GitHub for this repo. I can understand the first point, but don't understand the rationale for the other 3. Could this be elaborated here and in the root README? The third "rule" (samples_ prefix) doesn't seem to be consistently applied.
README.mdand sampleREADME.mdconveyor-samplesaws rolesamples_.conveyorfolder checked-in by mistake