Skip to content
This repository was archived by the owner on Sep 6, 2024. It is now read-only.

Comments

Scala 2.12 compatibility.#28

Merged
mrgambal merged 2 commits intodatamindedbe:masterfrom
mrgambal:dh_scala212_support
Jun 18, 2020
Merged

Scala 2.12 compatibility.#28
mrgambal merged 2 commits intodatamindedbe:masterfrom
mrgambal:dh_scala212_support

Conversation

@mrgambal
Copy link
Contributor

@mrgambal mrgambal commented Apr 8, 2020

Apache Spark has embraced the GA support for 2.12 since the version 2.4.1, that was released nearly a year ago.
The Amazon EMR v6.0.0 characterized by the adoption of Hadoop 3.2.1 (sic!) and Scala 2.12 (although the default JDK is still Coretto 8) has been released a month ago, hence I presume it would be nice to have cross-builds for the Lighthouse.

This PR was cherry-picked from #27, where you can observe the matrix builds, as currently the Circle CI config supports only 2.11.

Changelog:

  • enable cross-version builds for the projects;
  • fix compile-time warning.

Apache Spark has embraced the GA support for 2.12 since the version 2.4.1, that was released nearly a year ago.
The Amazon EMR v6.0.0 characterised by the adoption of Hadoop 3.2.1 (sic!) and Scala 2.12 (although the default JDK is still Coretto 8) has been released a month ago, hence I presume it would be nice to have cross-builds for the Lighthouse.

This PR was cherry-picked from datamindedbe#27, where you can observe the matrix builds, as currently the Circle CI config supports only 2.11.

Changelog:
- enable cross-version builds for the projects;
- fix compile-time warning.
@mrgambal mrgambal requested a review from EnverOsmanov May 6, 2020 06:09
@mrgambal
Copy link
Contributor Author

mrgambal commented Jun 18, 2020

I'm going to merge this one as it's not causing any changes to APIs, only adds the ability to build the library with Scala 2.12 support.
However, I am not aware of how your release process work, so I am leaving that to you @pascal-knapen .

UPD: I've run a couple of tasks using my own makeshift build on my clusters – looks good.

@mrgambal mrgambal merged commit e807eec into datamindedbe:master Jun 18, 2020
@mrgambal mrgambal deleted the dh_scala212_support branch June 18, 2020 10:12
@pascal-knapen
Copy link
Contributor

@mrgambal ok, I can do a release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants