This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Removed broken check_error on libssh2_sftp_seek64#22
Open
sourgrasses wants to merge 1 commit intodatanoise:masterfrom
Open
Removed broken check_error on libssh2_sftp_seek64#22sourgrasses wants to merge 1 commit intodatanoise:masterfrom
sourgrasses wants to merge 1 commit intodatanoise:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
lissh2_sftp_seek64returns void/nil, it can't be compared incheck_error, and it should catch the error when you try to read from or write to the handle anyway.