Conversation
aberazniova
force-pushed
the
update-dependencies
branch
5 times, most recently
from
d7e2bb8 to
bb9d760
Compare
aberazniova
force-pushed
the
update-dependencies
branch
from
bb9d760 to
5376354
Compare
| extends: [ | ||
| 'stylelint-config-datarockets', | ||
| 'stylelint-config-styled-components', | ||
| fs.existsSync(pathToPrettier) && 'stylelint-config-prettier', |
There was a problem hiding this comment.
Stylelint 15 deprecated all conflicting rules, so stylelint-config-prettier is no longer nessesary
https://www.npmjs.com/package/stylelint-config-prettier (see note)
lesha1201
left a comment
lesha1201
left a comment
There was a problem hiding this comment.
It's hard to review without diving into details but diving into detail will take too much time which doesn't make much sense in case of a deprecated project.
| @@ -15,58 +15,57 @@ | |||
| "node": ">=12" | |||
There was a problem hiding this comment.
| "node": ">=12" | |
| "node": ">=16" |
|
@lesha1201 thank you for your feedback. In this case, should we archive this repository or what your recommendation would be? cc @ezhlobo |
|
Either rewrite it completely to fit our needs for starting new projects or archive it for now. The first option is quite time-consuming and requires to involve multiple people to discuss all the conventions, stack, etc. |
|
@lesha1201 I got it...well, both options are sort of not fun...but having some action over the repo is surely needed because keeping dreact as-is makes things pretty misleading. Personally, I'm leaning to an option of archiving dreact. We haven't actively contributed nor use it for some quite long period of time. |
|
@Anastastasia-B I hate to say that but it seems like this PR won't be merged because it doesn't make sense to keep it going in the current situation. I see you've done some good job here and hope you made it to gain some good knowledge from this experience which would be beneficial to you anyways. |
3 participants
Updated the dependencies