Fixes databases with dots - add tilde_decode to table and db parameters#24
Open
voltagex wants to merge 2 commits intodatasette:mainfrom
Open
Fixes databases with dots - add tilde_decode to table and db parameters#24voltagex wants to merge 2 commits intodatasette:mainfrom
voltagex wants to merge 2 commits intodatasette:mainfrom
Conversation
Author
|
Oh yeah, the tests in this project crash on Windows but I believe this is an existing issue in Datasette, not anything you or I have added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a fix so that databases with dots in their filenames work.
Added a basic test too - this could be cleaned up but I just wanted to use some software, man.
Fixes #23