-
Notifications
You must be signed in to change notification settings - Fork 2
Wheel build changes necessary to support CASSPYTHON-3 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
absurdfarce
wants to merge
20
commits into
datastax:master
Choose a base branch
from
absurdfarce:python1428
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
336bf44
Updating to state of current work... while also removing existing sub…
absurdfarce ecbbe3c
Updating to use absurdfarce/python-driver
absurdfarce 1edae4f
Updating submodule to use latest commit on python1428 branch of absur…
absurdfarce ccee4f6
Update to reflect recent work on moving to pyproject.toml
absurdfarce 2d65174
Temporarily remove stripping of symbols from shared objects in order …
absurdfarce bcd8646
Revert "Temporarily remove stripping of symbols from shared objects i…
absurdfarce c06ba16
Let's try including an explicitly empty CFLAGS to avoid the compiler …
absurdfarce 15c4e8d
Trying the default gcc compilation args + stripping of symbols
absurdfarce aecd59c
Revert "Trying the default gcc compilation args + stripping of symbols"
absurdfarce 3af044e
Revert "Let's try including an explicitly empty CFLAGS to avoid the c…
absurdfarce efe43a3
Restoring the full Python build matrix - Python 3.9 + Python 3.14
absurdfarce 1ae3b6a
Update OSX configs to account for removal of MacOS 13 runner
absurdfarce 5096c6c
Bump target Python versions for MacOS
absurdfarce d49eb3d
Update python-driver to reflect recent pyproject.toml changes
absurdfarce 920678a
Trying out the script-based pyproject.toml update process
absurdfarce dfd3434
Formatting issue
absurdfarce 46c4135
A few minor fixes
absurdfarce ee369ed
Bump Python versions on Windows to Python 3.10 through 3.14.
absurdfarce f284c13
Formatting fix
absurdfarce 4b61782
Merge branch 'master' into python1428
absurdfarce File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule python-driver
updated
265 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import toml | ||
|
|
||
| import shutil | ||
| import sys | ||
|
|
||
| (pyproject_path, libev_includes,libev_libs) = sys.argv[1:] | ||
|
|
||
| pyproject_path_backup = pyproject_path + ".original" | ||
|
|
||
| shutil.move(pyproject_path, pyproject_path_backup) | ||
| the_toml = toml.load(pyproject_path_backup) | ||
|
|
||
| the_toml["tool"]["cassandra-driver"]["libev-includes"] = [libev_includes] | ||
| the_toml["tool"]["cassandra-driver"]["libev-libs"] = [libev_libs] | ||
|
|
||
| toml.dump(the_toml, open(pyproject_path, "w")) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bschoening What do you think about this? I'm okay with yanking Win32 wheel builds; they're broken anyway (see CASSPYTHON-5) and I'm not at all convinced it's worth it to try and fix them.