Open
Conversation
daurnimator
force-pushed
the
client.pooling
branch
2 times, most recently
from
f12647f to
073392a
Compare
daurnimator
commented
Aug 27, 2018
| if h2_settings then | ||
| -- TODO: check (and possibly change on connection?) | ||
| return false | ||
| end |
Owner
Author
There was a problem hiding this comment.
Should check MAX_CONCURRENT_STREAMS
daurnimator
commented
Aug 27, 2018
| end | ||
|
|
||
| if candidate.version < 2 then | ||
| -- Check if connection already in use (avoid pipelining) |
Owner
Author
There was a problem hiding this comment.
TODO: check pipeline depth instead.
Also, might want to find shortest pipeline in the pool?
daurnimator
commented
Aug 27, 2018
| end | ||
|
|
||
| -- Check to see if connection has been closed | ||
| local ok, err = candidate.socket:fill(1, 0) |
Owner
Author
There was a problem hiding this comment.
Factor out into a "is alive" function. Can be reused for cleaning the pool
daurnimator
force-pushed
the
client.pooling
branch
from
073392a to
3dfeaa0
Compare
daurnimator
force-pushed
the
client.dns_resolver
branch
from
5a80e99 to
6218598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.
Will close #10