-
Notifications
You must be signed in to change notification settings - Fork 31
Enable support for import file chooser #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b8004b9 to
750342a
Compare
Some reader classes may want to have a user select a file, instead of presenting an import box. This adds support for the feature. It will be used by the Moon+ reader class.
|
@stbenjam , you'd better also post a link to every PR you create to the https://www.mobileread.com/forums/showthread.php?t=241206 as well, because @davidfor isn't getting notifications from the GitHub. |
|
thank you. I desperately need this feature and look forward to the update. |
|
@stbenjam ,Can you send me the updated plug by you? I can't wait for having a try. Thank you. |
|
@Geo123abc , what feature are you talking about exactly? This PR adds file dialog support for bookmark importer classes, but none of the classes, except newly developed Moon Reader support (#23) uses it. |
|
@Geo123abc , theoretically these steps should help:
If you'll see any Python errors (in my case these were some other reader classes), then just delete files from where the errors are coming (in that PR code) and repeat the process. |
|
@Geo123abc , thank you. |
|
@stbenjam , I completely understand you. Please be patient. We're not in a hurry here with @davidfor being very occupied with other projects and not being able to timely review any PR coming in. I'm glad, that you're able to implement a Moon+ Reader integration, that works for you. Please don't let it disappear and not make any other Moon+ Reader + Calibre user happy. It will be reviewed eventually I guess. |
|
This is definitely a good idea. |
Some reader classes may want to have a user select a file, instead of
presenting a text box. This adds support for the feature.
It will be used by the Moon+ reader class.
Screenshot: