Skip to content

Fix CD argument behavior of dz-defservice#5

Open
tkf wants to merge 1 commit intodavidmiller:masterfrom
tkf:rm-dz-dir-excursion
Open

Fix CD argument behavior of dz-defservice#5
tkf wants to merge 1 commit intodavidmiller:masterfrom
tkf:rm-dz-dir-excursion

Conversation

@tkf
Copy link

@tkf tkf commented May 17, 2012

Specifying CD argument when using dz-defservice macro causes
NAME-start function to move the directory of the current buffer.
This problem is fixed by simply replacing dz-dir-excursion with
a let clause where default-directory is dynamically bound to CD.

Specifying CD argument when using dz-defservice macro causes
NAME-start function to move the directory of the current buffer.
This problem is fixed by simply replacing dz-dir-excursion with
a let clause where default-directory is dynamically bound to CD.
@maio
Copy link

maio commented May 24, 2013

Would this get merged into master someday? Changing directory of currently edited file is pretty annoying.

@bovid-19
Copy link

bovid-19 commented Jun 9, 2022

@davidmiller Is there a reason dz-dir-excursion is required?

The way I understand the documentation for the :cd keyword*, the patched version should be correct and it arguably makes the code easier to read.

If this wasn't an oversight and the patch doesn't work for you, would you merge one that adds this behaviour through another keyword, e.g. :dir, :path or :data?


* :cd - (string) The directory in which you would like the service to run

@camachojua
Copy link

camachojua commented Oct 11, 2022

I've recently forked this repo and I've started to update some deprecated functions (as per emacs 29) @tkf would you mind to point your PR to my fork? In this way we can start updating this amazing package

@gopar
Copy link

gopar commented Mar 27, 2023

Welps, guessing this aint getting merged anytime soon. I manually edited the file. Not great but its better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants