Implementation of String arrays in queries/insert/updates#51
Open
alexwen wants to merge 1 commit intodavidmoten:masterfrom
Open
Implementation of String arrays in queries/insert/updates#51alexwen wants to merge 1 commit intodavidmoten:masterfrom
alexwen wants to merge 1 commit intodavidmoten:masterfrom
Conversation
Owner
|
Sorry Alex, I'm a victim of too many email notifications and I let this slip. I'll keep it in mind and come back to this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #33
I went with a very narrow fix for solving my immediate use case. Support for varchar SQL arrays on non-H2 databases. I have only tested this against Postgres, though I did at least look at Oracle documentation for arrays to see that they create arrays in the same manner.
I did try a few things for more general purpose array handling but I was unable to easily infer the type from the Postgres metadata so I was wary of attempting anything too fancy and likely hurting any chance of cross database compatibility.
I still think it would be good to have a more general purpose pluggable mechanism as we discussed in #33 but that would take some deeper architectural deviations then I am comfortable undertaking at this time.
Please, let me know what your thoughts are.