[ImgBot] Optimize images #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 5,034.85kb -> 3,182.86kb (36.78%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/IntegrationTests-IntegrationTestsApp/testSimpleSnapshotTest_1@3x.png -- 117.37kb -> 1.95kb (98.34%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/IntegrationTests-IntegrationTestsApp/testSimpleSnapshotTest_1@2x.png -- 56.35kb -> 1.04kb (98.15%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/IntegrationTests-IntegrationTestsApp/testImageSnapshotTest_1@3x.png -- 109.67kb -> 2.71kb (97.53%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/IntegrationTests-IntegrationTestsApp/testImageSnapshotTest_1@2x.png -- 52.81kb -> 1.38kb (97.38%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/iTunesArtwork@1x.png -- 89.93kb -> 27.19kb (69.77%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-60@3x.png -- 11.19kb -> 4.75kb (57.59%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-83.5@2x.png -- 10.35kb -> 4.45kb (56.98%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-76@2x.png -- 9.39kb -> 4.13kb (55.98%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-Small-40@3x.png -- 7.23kb -> 3.38kb (53.3%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-60@2x.png -- 7.23kb -> 3.38kb (53.3%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-Small@3x.png -- 5.35kb -> 2.62kb (51%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-Small-40@2x.png -- 4.74kb -> 2.42kb (48.94%) /packages/rn-tester/RNTester/Images.xcassets/AppIcon.appiconset/Icon-Small@2x.png -- 3.34kb -> 1.91kb (42.71%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testLayoutExample_1-iOS12@2x.png -- 165.41kb -> 94.92kb (42.61%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/packages-rn-tester-js-RNTesterApp.ios/testLayoutExample_1-iOS16@3x.png -- 313.36kb -> 181.00kb (42.24%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testLayoutExample_1-iOS13@2x.png -- 165.64kb -> 95.88kb (42.11%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testSwitchExample_1-iOS12@2x.png -- 145.82kb -> 86.57kb (40.63%) /packages/rn-tester/js/assets/bottom-nav-apis-icon-active.png -- 1.83kb -> 1.10kb (39.84%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/packages-rn-tester-js-RNTesterApp.ios/testViewExample_1-iOS16@3x.png -- 440.45kb -> 268.53kb (39.03%) /packages/rn-tester/js/assets/bottom-nav-apis-icon-inactive.png -- 1.91kb -> 1.17kb (38.76%) /packages/rn-tester/js/assets/search-icon.png -- 1.69kb -> 1.06kb (37.21%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/packages-rn-tester-js-RNTesterApp.ios/testTextExample_1-iOS16@3x.png -- 562.33kb -> 361.08kb (35.79%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testSwitchExample_1-iOS13@2x.png -- 124.05kb -> 79.82kb (35.66%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/packages-rn-tester-js-RNTesterApp.ios/testSwitchExample_1-iOS16@3x.png -- 360.79kb -> 233.75kb (35.21%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testSliderExample_1-iOS12@2x.png -- 178.50kb -> 117.67kb (34.08%) /packages/rn-tester/js/examples/Accessibility/mixed.png -- 18.60kb -> 12.27kb (34%) /packages/rn-tester/js/assets/bottom-nav-components-icon-active.png -- 1.02kb -> 0.69kb (32.57%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testScrollViewExample_1-iOS12@2x.png -- 249.04kb -> 169.18kb (32.07%) /packages/rn-tester/js/assets/bookmark-outline-gray.png -- 1.05kb -> 0.71kb (31.97%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testScrollViewExample_1-iOS13@2x.png -- 248.32kb -> 169.12kb (31.9%) /packages/rn-tester/js/assets/relay@3x.png -- 4.23kb -> 2.98kb (29.51%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testViewExample_1-iOS12@2x.png -- 234.39kb -> 166.65kb (28.9%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testViewExample_1-iOS13@2x.png -- 233.34kb -> 167.45kb (28.24%) /packages/rn-tester/js/assets/bottom-nav-components-icon-inactive.png -- 1.00kb -> 0.72kb (27.88%) /packages/rn-tester/js/assets/bookmark-outline-blue.png -- 1.01kb -> 0.74kb (26.98%) /packages/rn-tester/RNTester/RNTesterBundle/ImageInBundle.png -- 34.68kb -> 25.48kb (26.54%) /packages/rn-tester/RNTester/RNTesterBundle/OtherImages.xcassets/ImageInAssetCatalog.imageset/react-logo.png -- 34.68kb -> 25.48kb (26.54%) /packages/rn-tester/js/assets/flux@3x.png -- 5.79kb -> 4.27kb (26.24%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testTextExample_1-iOS12@2x.png -- 315.50kb -> 242.51kb (23.14%) /packages/rn-tester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios/testTextExample_1-iOS13@2x.png -- 318.66kb -> 245.89kb (22.84%) /packages/rn-tester/js/assets/bottom-nav-bookmark-outline.png -- 0.91kb -> 0.71kb (21.74%) /packages/rn-tester/js/assets/bottom-nav-bookmark-fill.png -- 0.75kb -> 0.60kb (20.05%) /packages/rn-tester/android/app/src/main/ic_launcher-playstore.png -- 41.86kb -> 36.99kb (11.65%) /packages/rn-tester/android/app/src/main/res/drawable/tv_banner.png -- 28.27kb -> 26.00kb (8.04%) /packages/rn-tester/js/assets/slider@2x.png -- 1.94kb -> 1.83kb (5.68%) /packages/rn-tester/js/assets/trees.jpg -- 256.46kb -> 244.25kb (4.76%) /packages/rn-tester/js/assets/empty.png -- 22.29kb -> 21.25kb (4.66%) /packages/rn-tester/js/examples/Accessibility/check.png -- 25.32kb -> 24.32kb (3.95%) /packages/react-native/template/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png -- 9.03kb -> 8.90kb (1.51%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
daviz00
pushed a commit
that referenced
this pull request
Nov 28, 2023
Summary: Pull Request resolved: facebook#41466 ## Context In open source, all apps use the same turbomodulemanager delegate (i.e: the default delegate). This diff introduces the buck infra that makes the oss default delegate work for meta apps. Concretely, we are going to make React Native use the same delegate for **all** Meta apps. Each Meta app will: 1. At build time, generate a unique TMProvider map 2. At app init time, initialize the default delegate with the TMProvider map. ## Implementation **Step #1:** At build time, generate a unique TMProvider map **Insight:** Buck genrules can accept, as input, the output of a buck query. So, here's how we get this done: 1. Buck query (i.e: input to Genrule): Given the app's deps, query all the schemas in the app. 2. Genrule: Read the schemas to generate the TMProvider map. The TMProvider map will also contain **all** the app's C++ module codegen. Concretely: 1. This diff introduces a macro: rn_codegen_appmodules(deps). 2. rn_codegen_appmodules(deps) generates appmodules.so, which contains the TMProvider map. **Step facebook#2:** At app init time, initialize the default delegate with the TMProvider map. This is how we'll initialize the DefaultTurboModuleManagerDelegate: 1. DefaultTurboModuleManagerDelegate will load appmodules.so during init. 2. When loaded, appmodules.so will assign the code-generated TMProvider map to DefaultTurboModuleManagerDelegate. ## Impact This should allow us to: 1. Get one step closer to getting rid of the `js1 build turbomodule-manager-delegates --target <app>` script 3. Remove the TurboModuleManagerDelegate from React Native's public API. (Because we use one delegate for all React Native apps in Meta and OSS) Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D50988397 fbshipit-source-id: 0ca5dec14e2dae89ec97f5d39a182c7937c5c7bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 37% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family