Use default config when not set in <alias>.toml#192
Open
patrikhl wants to merge 1 commit intodavrodpin:masterfrom
Open
Use default config when not set in <alias>.toml#192patrikhl wants to merge 1 commit intodavrodpin:masterfrom
patrikhl wants to merge 1 commit intodavrodpin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #156
Since the value from
aliasis always assigned, it overwrites the default value ($HOME/.ssh/config). Checking whetheralias.SshConfigis empty before overwriting fixes this.This PR only addresses
SshConfig. I guess it would make sense to go through the other options as well, to see which ones should not always be overwritten.