Big changes

[alogic0]

Hi @dbaynard! I've made some modifications to your code and send this PR for your consideration. The main changes are:

1. conversion from lhs to hs
2. removing HtmlVariant as parameter, because we use only html5
3. add-hoc support for some html attributes is added to standalone generation
4. <tt> tag is accepted, but converted to <code>

Also I don't use Stack, so there is no stack.yaml, but it can be generated from package.yaml, I think. The full list of other changes you can see in comments to the commits.

I'd like to see the project on Hackage and ready to maintain it or co-maintain.
Hope for your feedback.
Oleg Tsybulskyi alogic0@gmail.com

[dbaynard]

I'll take a look later. As for hackage, there's a plan to integrate with lucid itself in the new year.

[alogic0]

About integration. The negative is that slightly less than all sites use deprecated or obsolete tags, they assign value to standalone parameters and have another bugs in formatting, that will always crash your convertor. Or svg tag, for example. It's a separate task to add support for it, using lucid-svg. Would you integrate lucid-svg too? So, adding various tweaks is simpler when you have a separate package.

On the positive side, adding support for some tags can be done directly in Lucid.

So, my opinion is that it's better to follow the Unix phylosophy in this case and keep separate programs for separate tasks.

[dbaynard]

You're right to call this 'big changes'. Some look necessary, some look good, some I'll need to check further and some — especially removing the license file and changing to reference your own repository — I cannot accept (please take care not to remove the license file).

You mention that malformed input can crash the converter; if you've found examples, please raise issues. If these are examples your changes fix, indicate that too.

It will take me a short while to go through this, but briefly

• I won't merge the directory changes, the deletion of the license file, the update of the cabal file to refer to your repo and the deletion of the stack.yaml file,
• I'm concerned with some of the ad-hoc generation, and it should probably be done in a more systemized way,
• It's not clear what are bug fixes, but without a test suite (see Add test suite #1) it's tricky for me to judge.
• The rest is probably fine.

It'll take a while for me to do this; I recommend you continue using your own fork in the meanwhile.

As for the integration comments, the lucid package has no corresponding executable, and it makes sense that such an executable would either generate lucid code or convert that code to html. If the lucid maintainers want this I will support them.

The lucid-svg point is interesting, though — thank you for bringing that to my attention.

[alogic0]

Thank for feedback! First of all, my apologies for not cleaning package.yaml. The License is preserved, but because of merging directories I left only one of two copies. I sent you PR from this branch and License is on the place there. In any case, I don't pretend to point to my repository.

My collection of closed issues with examples is here.

I plan to provide a test suite. At the moment the files for testing are put here.