-
-
Notifications
You must be signed in to change notification settings - Fork 60
Add Search endpoint #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmn4
wants to merge
1
commit into
dblock:master
Choose a base branch
from
pmn4:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| module IEX | ||
| module Endpoints | ||
| module Search | ||
| def search(fragment, options = {}) | ||
| raise ArgumentError, 'Fragment is required' if fragment.blank? | ||
|
|
||
| get([ | ||
| 'search', | ||
| fragment | ||
| ].compact.join('/'), options).map do |data| | ||
| # Per the IEX documentation, any type of Resource could be returned | ||
| # this should become a case statement: | ||
| # https://iexcloud.io/docs/api/#search | ||
| IEX::Resources::Company.new(data) | ||
| end | ||
| rescue Faraday::ResourceNotFound => e | ||
| raise IEX::Errors::SearchNotFoundError.new(fragment, e.response[:body]) | ||
| end | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| require_relative 'errors/search_not_found_error' | ||
| require_relative 'errors/symbol_not_found_error' | ||
| require_relative 'errors/client_error' | ||
| require_relative 'errors/permission_denied_error' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| module IEX | ||
| module Errors | ||
| class Error < StandardError; end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| require_relative 'error' | ||
|
|
||
| module IEX | ||
| module Errors | ||
| class SearchNotFoundError < Error | ||
| attr_reader :response | ||
| attr_reader :fragment | ||
|
|
||
| def initialize(fragment, response) | ||
| @response = response | ||
| @fragment = fragment | ||
| super %(Fragment "#{fragment}" Not Found) | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| require 'spec_helper' | ||
|
|
||
| describe IEX::Endpoints::Search do | ||
| context '#search' do | ||
| # Search falls outside of the normal testing because it is not exactly | ||
| # RESTy. The search endpoint (eventually) can return any type of resource | ||
|
|
||
| include_context 'client' | ||
|
|
||
| before do | ||
| # search is not supported on the free tier, except in the sandbox. In | ||
| # order for VCR to record the response, we need the endpoint to work | ||
| client.endpoint = 'https://sandbox.iexapis.com/v1' | ||
| # using the documentation-provided token to use in the Sandbox | ||
| client.publishable_token = 'Tsk_341c973d296e4e18aa61dd63050ce235' | ||
| end | ||
|
|
||
| it 'searches for resources', vcr: { cassette_name: 'client/search/msft' } do | ||
| results = client.search('msft') | ||
| results.each do |result| | ||
| expect(result).to be_a(IEX::Resources::Company) | ||
| end | ||
| end | ||
|
|
||
| it 'handles missing search terms', vcr: { cassette_name: 'client/search/missing' } do | ||
| expect { client.search('') } | ||
| .to raise_error(ArgumentError, 'Fragment is required') | ||
| end | ||
|
|
||
| it 'handles unknown search terms', vcr: { cassette_name: 'client/search/unknown' } do | ||
| expect(client.search('unreconized-search-term')).to be_empty | ||
| end | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. And create a base resource for anything unsupported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, they have not released this feature yet, the docs just mention that it is coming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem supporting something in pre-release, but we have to say it in README and point to whatever IEX docs that say the same