Skip to content

chore: Update CI, pre-commit, ruff rules and fix several lint problems#61

Merged
pbadillatorrealba merged 4 commits intodevelopfrom
chore/update_ci
Jul 22, 2025
Merged

chore: Update CI, pre-commit, ruff rules and fix several lint problems#61
pbadillatorrealba merged 4 commits intodevelopfrom
chore/update_ci

Conversation

@pbadillatorrealba
Copy link
Member

@pbadillatorrealba pbadillatorrealba commented Jul 22, 2025

This pull request introduces several updates to the codebase, focusing on modernizing dependencies, enhancing workflows, improving documentation, and refining examples. The changes aim to align the project with current best practices and streamline development processes.

Notable changes:

  • Dropped compatibility with Python 3.7, 3.8, and 3.9; the minimum supported Python version is now 3.10.
  • Resolved several Ruff linting rules as part of the migration from flake8 to Ruff.

Workflow and Dependency Updates:

  • .github/workflows/ci.yaml: Upgraded GitHub Actions dependencies (actions/checkout to v3, actions/setup-python to v4) and updated Python version from 3.7 to 3.10. Added a matrix strategy to test across Python versions 3.10 to 3.13. Removed flake8 linting step.
  • .pre-commit-config.yaml: Replaced flake8 with Ruff for linting and formatting. Upgraded pre-commit-hooks to v5.0.0 and added new hooks like check-json, check-toml, and detect-private-key.

Documentation Improvements:

  • docs/conf.py: Modernized code by using f-strings for intersphinx configuration and added type hints for the setup function.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the WEFE codebase by updating CI workflows, replacing flake8 with Ruff for linting, and refactoring the codebase to use modern Python syntax and best practices. The changes focus on improving code quality, consistency, and maintainability while updating development tools.

  • Updated GitHub Actions workflows to test Python 3.10-3.13 and removed flake8 in favor of Ruff
  • Modernized type annotations using built-in generics (list[str] instead of List[str])
  • Replaced .format() and % string formatting with f-strings throughout the codebase
  • Updated exception handling, import statements, and various code quality improvements

Reviewed Changes

Copilot reviewed 61 out of 62 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
.github/workflows/ci.yaml Updated Python versions and GitHub Actions, removed flake8
.pre-commit-config.yaml Replaced flake8 with Ruff and added new hooks
pyproject.toml Completely restructured Ruff configuration with modern rules
wefe/ modules Modernized type annotations, f-strings, and code patterns
tests/ modules Updated test functions with type hints and modern syntax
examples/ notebooks Fixed formatting and import organization

@pbadillatorrealba pbadillatorrealba self-assigned this Jul 22, 2025
@pbadillatorrealba pbadillatorrealba merged commit a606546 into develop Jul 22, 2025
4 checks passed
@pbadillatorrealba pbadillatorrealba deleted the chore/update_ci branch July 22, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants