chore: Update CI, pre-commit, ruff rules and fix several lint problems#61
Merged
pbadillatorrealba merged 4 commits intodevelopfrom Jul 22, 2025
Merged
chore: Update CI, pre-commit, ruff rules and fix several lint problems#61pbadillatorrealba merged 4 commits intodevelopfrom
pbadillatorrealba merged 4 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the WEFE codebase by updating CI workflows, replacing flake8 with Ruff for linting, and refactoring the codebase to use modern Python syntax and best practices. The changes focus on improving code quality, consistency, and maintainability while updating development tools.
- Updated GitHub Actions workflows to test Python 3.10-3.13 and removed flake8 in favor of Ruff
- Modernized type annotations using built-in generics (
list[str]instead ofList[str]) - Replaced
.format()and%string formatting with f-strings throughout the codebase - Updated exception handling, import statements, and various code quality improvements
Reviewed Changes
Copilot reviewed 61 out of 62 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Updated Python versions and GitHub Actions, removed flake8 |
.pre-commit-config.yaml |
Replaced flake8 with Ruff and added new hooks |
pyproject.toml |
Completely restructured Ruff configuration with modern rules |
wefe/ modules |
Modernized type annotations, f-strings, and code patterns |
tests/ modules |
Updated test functions with type hints and modern syntax |
examples/ notebooks |
Fixed formatting and import organization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the codebase, focusing on modernizing dependencies, enhancing workflows, improving documentation, and refining examples. The changes aim to align the project with current best practices and streamline development processes.
Notable changes:
Workflow and Dependency Updates:
.github/workflows/ci.yaml: Upgraded GitHub Actions dependencies (actions/checkoutto v3,actions/setup-pythonto v4) and updated Python version from 3.7 to 3.10. Added a matrix strategy to test across Python versions 3.10 to 3.13. Removed flake8 linting step..pre-commit-config.yaml: Replaced flake8 with Ruff for linting and formatting. Upgradedpre-commit-hooksto v5.0.0 and added new hooks likecheck-json,check-toml, anddetect-private-key.Documentation Improvements:
docs/conf.py: Modernized code by using f-strings for intersphinx configuration and added type hints for thesetupfunction.