Hack Patch for 1.3.x compatibility with 1.2.x fallback#2
Open
JasonGiedymin wants to merge 2 commits intodcramer:masterfrom
Open
Hack Patch for 1.3.x compatibility with 1.2.x fallback#2JasonGiedymin wants to merge 2 commits intodcramer:masterfrom
JasonGiedymin wants to merge 2 commits intodcramer:masterfrom
Conversation
Author
|
My fork's trunk has newer code from the last tagged pull req. |
Owner
|
Going to review this and try to get it in sometime this week, thanks! |
Author
|
Any news? :-) |
|
Looking for any news here too. |
Author
|
I'll bump it too. |
|
Looking at this, I'm not as sure this handles the Django 1.3 compatibility. I think there's a bit more work to get it to support |
Author
|
I agree, again this was a hack :-) There are many cases where this will break but so far it's working for my simple single cache (no pool) case. I'd have done more work but can't find the time :-( |
|
Check out Issue #3 and pull request 3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hack patch. I believe that nexus_modules.py should be changed to accept the new CACHES dictionary instead and have already started work on that. It also looks like changes for 1.4 could change things even more...
This patch however should retain existing test coverage as the work was done up front to conform the new cache designation to the old.