More explicit error messages during FASTA parsing#77
Open
stelzch wants to merge 1 commit intoddarriba:masterfrom
Open
More explicit error messages during FASTA parsing#77stelzch wants to merge 1 commit intoddarriba:masterfrom
stelzch wants to merge 1 commit intoddarriba:masterfrom
Conversation
Previously, parsing errors in FASTA files were ignored and subsequent sequences quietly dropped. By checking the return value of the parsing routine, the program can now warn the user if illegal characters are encountered and refuses to continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, parsing errors in FASTA files were ignored and subsequent sequences quietly dropped. By checking the return value of the parsing routine, the program can now warn the user if illegal characters are encountered and refuses to continue.
Example alignment:
Before the patch
The error occurs because we only have four sequences, if we had more all sequences after the error would be dropped quietly.
With the patch