Refactor recording pipeline and harden DevTools adapter#5
Merged
Conversation
Restructure the recording pipeline (phases 1-3) and apply post-review improvements: fix false-positive locator confidence penalties, add dblclick/hover support, remove dead selectorPolicy code, deduplicate slugify, normalize first-navigate in DevTools imports, improve ARIA selector parsing for extra attributes and shadow DOM, and add runRecordFromFile test coverage. 564 tests passing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vriesd
force-pushed
the
refactor/recording-pipeline
branch
from
0ec9316 to
35b3d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
escapeSingleQuotesto handle pre-existing backslashesdblclickandhoverstep type support (schema, executor, DevTools adapter)selectorPolicyoption (accepted but never used)slugifybetween recorder.ts and record-service.tsnormalizeFirstNavigatein--from-fileimport path with baseUrl extractionrunCodegenInternalintorunCodegenrunRecordFromFiletest coverage (5 tests)Test plan
npx tsc --noEmitclean for all touched files--from-fileimport normalizes navigate URLs to relative pathsdoubleClickandhoverDevTools steps convert and play back correctly🤖 Generated with Claude Code