fix for code scanning alert: Workflow does not contain permissions#2
Merged
ron-tsarevsky merged 7 commits intomainfrom Sep 10, 2025
Merged
fix for code scanning alert: Workflow does not contain permissions#2ron-tsarevsky merged 7 commits intomainfrom
ron-tsarevsky merged 7 commits intomainfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/de-id/ffmpeg-kit/security/code-scanning/37
To fix the problem, we should explicitly declare the
permissions:key at the workflow root (so it applies to all jobs, unless overridden), specifying only the minimal access needed for this workflow. At a minimum, CodeQL suggestscontents: read, but because the workflow creates releases (softprops/action-gh-release) and uploads artifacts, we likely need additional permissions:contents: write(for creating releases/assets)actions: write(for uploading artifacts, thoughupload-artifactdoes not require this)The best change is to add the following block just after the workflow
nameand beforeon:(so it covers all jobs in the workflow):If you want to start with the most restrictive and only escalate if you discover errors, you can use
contents: readinitially. However, theaction-gh-releasewill requirewriteon contents to create releases. Socontents: writeis correct for this workflow.Only the top region of
.github/workflows/android-build-scripts-did.ymlneeds to be changed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.