Open
Conversation
Previously, there was no good way to tell which arguments were really set when doing a mode set. We now set all the unused ones to -1, which is probably not valid. The application can look through 8 arguments and see the unset ones. It's still a bit of a hack, but it's better.
Supporting this means setting G0/G1, supporting Shift In/Out, etc.
When Unicode decoding is turned on, if we display the Unicode equivalent of an ACS character, we actually map it to the ACS character.
Previously, if we were doing SGR with multiple arguments, the first argument ends up determining the enabled state of all the others!
Previously, in form 1, this missed clearing the bottom line.
This implements CSI<L>;<H>r, which lets a program specify a range of lines to scroll, leaving others alone. It also implements code *similar* to how VT terminals deal with it when a character is written to the last column in a line. It essentially defers actually advancing the line, because there are cases where we don't want to (at least not yet), e.g., when the cursor wraps onto the next line and immediately does a CR. The behavior is not 100% the same as a VT, but it is close, and I haven't yet noticed bad behavior.
This is used by the linux terminfo to scroll up.
Since we're currently aiming at the "linux" terminfo entry, the key constants need to be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I get the sense that libtmt does not top your list of priorities at this time, but I've recently done a chunk of work on it and wanted to make sure you were at least aware whether you decide you want any of the changes or not. If for no other reason than so you know that your work on libtmt continues to be appreciated!
(I actually wouldn't recommend just pulling this at any rate, since it includes some potentially breaking changes, e.g., it's more aimed at the "linux" terminfo entry than "ansi" now. "ansi" was no longer working right for me... I suspect changes to the terminfo database broke things, but it also could have been something in tmux.)