#shy-lizard npm-modules #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementing remaining functions
breyana
suggested changes
Feb 21, 2017
breyana
left a comment
breyana
left a comment
There was a problem hiding this comment.
Overall, try to rewrite the methods when doing NPM modules instead of using the methods. Also, when making tests, try to have more than one test case. Try to break your code by doing edge cases.
| @@ -0,0 +1,5 @@ | |||
| <head> | |||
| <title> This is only a Test </title> | |||
There was a problem hiding this comment.
This is the only page that comes up when I attempt to load the site
|
|
||
| /* GET home page. */ | ||
| router.get('/', function(req, res, next) { | ||
| res.render('index', { title: 'NPM Modules for JS' }); |
There was a problem hiding this comment.
I think this is rendering index.html instead of index.pug?
| @@ -0,0 +1,6 @@ | |||
| module.exports =function ( str ) { | |||
| @@ -0,0 +1,3 @@ | |||
| module.exports = function (num1){ | |||
| return Math.ceil(num1) | |||
There was a problem hiding this comment.
I'd try rewriting .ceil in code instead of using .ceil
| @@ -0,0 +1,4 @@ | |||
| module.exports = function(num1 , num2){ | |||
| // 1.5){ | |||
There was a problem hiding this comment.
Leave out comments in the final product
| @@ -0,0 +1,6 @@ | |||
| module.exports = function min( inputArray ) { | |||
|
|
|||
| return Math.min.apply(null, inputArray) | |||
There was a problem hiding this comment.
Try to rewrite .min instead of using .min
Owner
Author
|
thank you!...
…On Tue, Feb 21, 2017 at 9:49 AM, breyana ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Overall, try to rewrite the methods when doing NPM modules instead of
using the methods. Also, when making tests, try to have more than one test
case. Try to break your code by doing edge cases.
------------------------------
In public/index.html
<#2 (comment)>:
> @@ -0,0 +1,5 @@
+<head>
+ <title> This is only a Test </title>
This is the only page that comes up when I attempt to load the site
------------------------------
In routes/index.js
<#2 (comment)>:
> @@ -0,0 +1,9 @@
+var express = require('express');
+var router = express.Router();
+
+/* GET home page. */
+router.get('/', function(req, res, next) {
+ res.render('index', { title: 'NPM Modules for JS' });
I think this is rendering index.html instead of index.pug?
------------------------------
In spec/camelcase.js
<#2 (comment)>:
> @@ -0,0 +1,6 @@
+module.exports =function ( str ) {
add a space after the equals sign
------------------------------
In spec/ceil.js
<#2 (comment)>:
> @@ -0,0 +1,3 @@
+module.exports = function (num1){
+ return Math.ceil(num1)
I'd try rewriting .ceil in code instead of using .ceil
------------------------------
In spec/divide.js
<#2 (comment)>:
> @@ -0,0 +1,4 @@
+module.exports = function(num1 , num2){
+ // 1.5){
Leave out comments in the final product
------------------------------
In spec/min.js
<#2 (comment)>:
> @@ -0,0 +1,6 @@
+module.exports = function min( inputArray ) {
+
+ return Math.min.apply(null, inputArray)
Try to rewrite .min instead of using .min
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APuAkAqo23hZOVa-IQyFGytF-YzZrQnpks5reyOTgaJpZM4MHmKH>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.