Skip to content

Conversation

@debrayc
Copy link
Owner

@debrayc debrayc commented Feb 21, 2017

No description provided.

Copy link

@HJBowers HJBowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you started setting up this project like a full stack, including routes and views, although your specs don't require that. In fact, your specs are completely empty. From my memory of doing this project in the past, I think it just requires you to build tests and source files. So, using express is unnecessary.
It looks like your source files are well written, and it's good that you started implementing various methods. In the future, I would recommend trying to build these out without using any methods (this makes some of the algorithms significantly more difficult). I'd also recommend attempting some of the more difficult algorithms if you decide to do this project again.
Over all, your code looks good, and your formatting is clean. Your tests also look good, although it would be useful to have multiple cases to test. If this was your first exposure to testing, then you're doing great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants