-
Notifications
You must be signed in to change notification settings - Fork 0
#shy-lizard npm-modules #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: empty2
Are you sure you want to change the base?
Conversation
implementing remaining functions
HJBowers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you started setting up this project like a full stack, including routes and views, although your specs don't require that. In fact, your specs are completely empty. From my memory of doing this project in the past, I think it just requires you to build tests and source files. So, using express is unnecessary.
It looks like your source files are well written, and it's good that you started implementing various methods. In the future, I would recommend trying to build these out without using any methods (this makes some of the algorithms significantly more difficult). I'd also recommend attempting some of the more difficult algorithms if you decide to do this project again.
Over all, your code looks good, and your formatting is clean. Your tests also look good, although it would be useful to have multiple cases to test. If this was your first exposure to testing, then you're doing great! :)
No description provided.