Fix: don't pass ref to react-polyglot 'translate' function component#2607
Fix: don't pass ref to react-polyglot 'translate' function component#2607erquhart merged 1 commit intodecaporg:masterfrom erezrokah:fix/ref_on_function_component_warning
Conversation
|
It does look like this fell out of use, which would mean the places we're running |
|
I would normally say we should drop the last two optional args for |
You're right I though about removing the redundant parameters all together, but thought it might have some value in explicitly showing the ref is not needed here. |
|
Hey I am experiencing a similar issue was just curious if this hasn't gotten fixed because only 8 / 13 checks are passing on the review. Let me know, I can help move it along if needed possibly. |
Fixes #2098
translatecreates a function component hence the warning.If the
refis really needed (I'm assuming not at the moment) we can:react-reduxand useforwardRef:https://react-redux.js.org/api/connect#options-object
or