Draft
Conversation
aleortega
force-pushed
the
poc/attestations
branch
from
58a1a4d to
dd2f5d4
Compare
| beneficiary: string | ||
| itemUrn: string | ||
| issuedAt: number | ||
| expiresAt: number |
Contributor
There was a problem hiding this comment.
WDYT about making it clear here that expiresAt is in seconds?
Comment on lines
+120
to
+130
| for (const attestation of attestations) { | ||
| const result = await validateOwnershipAttestation(attestation, deployer, timestamp) | ||
|
|
||
| if (result.valid && result.itemUrn) { | ||
| validUrns.add(result.itemUrn.toLowerCase()) | ||
| } else if (result.reason) { | ||
| errors.push(result.reason) | ||
| } | ||
| } | ||
|
|
||
| return { validUrns, errors } |
Contributor
There was a problem hiding this comment.
WDYT about doing all of this concurrently using Promise.all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP